Summary: | TODO: Task not found if comment after last closing brace | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Jerome Lanneluc <jerome_lanneluc> |
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> |
Status: | VERIFIED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | ||
Version: | 2.0 | ||
Target Milestone: | 2.1 M3 | ||
Hardware: | PC | ||
OS: | Windows 2000 | ||
Whiteboard: | |||
Bug Depends on: | 23096 | ||
Bug Blocks: |
Description
Jerome Lanneluc
2002-10-14 07:21:26 EDT
The last line comment needs to be closed with a line break. Otherwise the scanner should reject it and report an unterminated comment. See bug 23096. It is easy to fix the scanner, but the complete fix (which would include the following line break has part of the line comment) breaks the code formatter. So until we don't have the new formatter ready, I cannot release 23096. If the line comment is properly closed, it is easy to add the TODO: detection. In fact if the line comment ends with a line break, there is nothing to change. Do we want to be able to report TODO: tasks inside line comments which are not properly closed? To be consistent, we should check this kind of "invalid line comments" until bug 23096 is fixed. Fixed and released in 2.1 stream. Regression tests added. Verified. |