Bug 247408

Summary: [Net] Deprecate getProxyDataForHost(String) in the IProxyService API
Product: [Eclipse Project] Platform Reporter: Pawel Pogorzelski <pawel.pogorzelski1>
Component: TeamAssignee: Pawel Pogorzelski <pawel.pogorzelski1>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: Szymon.Brandys
Version: 3.5   
Target Milestone: 3.5 M4   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch_v01
none
Patch_v02 pawel.pogorzelski1: iplog+

Description Pawel Pogorzelski CLA 2008-09-16 04:03:58 EDT 
Build ID: I20080903-1200

Methods getProxyDataForHost(String) and getProxyDataForHost(String, String) are error prone. First of all it might be unclear to clients how the methods operate. Also, String class is not the best choice to represent hosts since it does not enforce any constraints on arguments passed.

The methods should be deprecated and a new method getProxyDataForHost(URL host) should be introduced. The new method should return proxy settings for a given protocol type.
Comment 1 Pawel Pogorzelski CLA 2008-11-21 10:03:48 EST 
Created attachment 118476 [details]
Patch_v01

Szymon, what do you think about the patch?
Comment 2 Pawel Pogorzelski CLA 2008-11-21 10:35:41 EST 
Created attachment 118481 [details]
Patch_v02
Comment 3 Szymon Brandys CLA 2008-11-21 10:42:47 EST 
Looks good. Thanks Pawel.
Comment 4 Tomasz Zarna CLA 2008-11-21 11:01:18 EST 
Released to HEAD.