Bugzilla – Full Text Bug Listing
| Summary: | [Trim] Toggle StatusLine | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Laurent Muller <laurent.muller> | ||||
| Component: | IDE | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | ASSIGNED --- | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | Keywords: | helpwanted | ||||
| Version: | 3.4 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Laurent Muller
Created attachment 112175 [details]
First implementation
Thanks Laurent...patches are always a welcome sight...;-) Removing 3.5 target milestone. We are in the end-game now. Please have a look and decide if this should be targeted at 3.6. Laurent, when you say 'status line' do you expect the result to be that -everything- in the bottom trim is hidden or just the StatusLine itself (and not the ProgressBar...)? What I want, if possible, it's that EVERYTHING in the bottom trim is hidden like in the attached code. Laurent, I've taken a look at the patch and like it, simple understandable code always makes folks life easier... Here's a few suggestions on areas you may want to take a look at: Persistence: If someone executes this command then it should likely stay in that state across re-launches of the eclipse sessions (see bug 158642). What happens if new trim gets added to the trim after 'hiding'? For example you can run the toggle command and then show the 'Heap Status' (Window -> Preferences... -> General has a checkbox). The current implementation will now have the Heap Status widget all by itself in the trim. BTW, what were the restrictions you mentioned in your description? Ideally, when trim is added, ITrimManager must be send messages to listeners to said that something happened.
The restrictions I mentioned is about the dependency of the WorkbenchWindow, ITrimManager and the IWindowTrim objects. All this classes are "internal" and I must add the @SuppressWarnings("restriction") attribute.
Laurent, I'll gladly review any patches you want to put here but I'm going to remove the 3.6 milestone (it's reserved for things that *have to* get into 3.6). This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |