Bug 245198

Summary: [dstore] ServerLauncherProperties not restored
Product: [Tools] Target Management Reporter: Masao Nishimoto <e03616>
Component: RSEAssignee: David Dykstal <ddykstal.eclipse>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P1 CC: ddykstal.eclipse, dmcknigh
Version: unspecified   
Target Milestone: 3.1 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 252019    

Description Masao Nishimoto CLA 2008-08-25 21:33:03 EDT
This is from 243128.

RSEDOMImporter.restoreConnectorService() has the following logic:

  for (all children of connector service node) {
    restore subsystem;
    if (subsystem != null && service == null) {           ... (A)
       get service associated with the subsystem;         ... (B)
       if (service != null) {
          if (configuration supports server launcher properties) {
             create server_launcher;
             if (server_launcher != null) {
               get server launcher properties;            ... (C)
               ..

If the first subsystem has service but does not have server launcher, the service is filled at the line (B), but (C) is not executed.  For other subsystems, since service is already filled, condition at the line (A) is not satisfied, and (C) is never executed, even if the subsystem has server launcher.
Comment 1 David Dykstal CLA 2008-08-25 21:47:42 EDT
Thanks. I will look at this this week.
Comment 2 David McKnight CLA 2008-10-24 12:26:42 EDT
To fix this we need to make sure to check whether the server launcher properties have been restored - if not, then try to restore them for the next subsystem configurations until it has been restored. 

I've committed the fix for this and opened the backport, bug 252019.
Comment 3 David McKnight CLA 2008-11-07 14:40:38 EST
The fix was committed earlier.