Bug 244579

Summary:

[api] move task editor extension out of the sandbox

Product:

z_Archived

Reporter:

David Green <greensopinion>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jingweno

Version:

dev

Keywords:

noteworthy, plan

Target Milestone:

3.1

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

244650, 245187

Attachments:

Description	Flags
first crack at moving extension out of the sanbox (not complete)	none
mylyn/context/zip	none
reimplemented against head	none
mylyn/context/zip	none
patch	none
mylyn/context/zip	none

Description David Green

2008-08-19 13:18:50 EDT

the task editor extension is currently in the sandbox.  Moving this into Mylyn proper is a 3.1 release goal

Comment 1 David Green

2008-08-25 20:22:49 EDT

Created attachment 110874 [details]
first crack at moving extension out of the sanbox (not complete)

Comment 2 David Green

2008-08-25 20:22:51 EDT

Created attachment 110875 [details]
mylyn/context/zip

Comment 3 David Green

2008-10-06 11:40:30 EDT

Created attachment 114322 [details]
reimplemented against head

reimplemented in the simplest form possible.
Steffen, this one's ready for you!

Comment 4 David Green

2008-10-06 11:40:36 EDT

Created attachment 114323 [details]
mylyn/context/zip

Comment 5 Steffen Pingel

2008-10-06 17:42:29 EDT

Thanks for your help David. Huge refactoring patches like this are difficult to review. It's usually easier if refactorings are done by the committer who is responsible for the component that is being changed. I would also like to review the code and API while moving it from the sandbox so I'll take this bug for now.

Comment 6 David Green

2008-10-06 17:45:42 EDT

(In reply to comment #5)
> Thanks for your help David. Huge refactoring patches like this are difficult to
> review. 

What I've found works well is to apply the patch, then compare the source tree against the latest revision in the repository.  The Eclipse compare editor is great at showing differences across multiple files.

> I would also like to review
> the code and API while moving it from the sandbox so I'll take this bug for now.

Ok, great.  I look forward to seeing this one completed.

Comment 7 Steffen Pingel

2008-10-16 23:20:59 EDT

I have moved the extension point and merged the code from the extensible task editor classes in the sandbox. Note that I have temporarily disabled default associations between repositories and markup languages until the configuration UI is moved into main as well. The configuration from the context menu is now available for all repositories and WikiText already works JIRA and Trac!

Comment 8 Steffen Pingel

2008-10-16 23:21:57 EDT

Created attachment 115335 [details]
patch

Comment 9 Steffen Pingel

2008-10-16 23:22:00 EDT

Created attachment 115336 [details]
mylyn/context/zip

Comment 10 Steffen Pingel

2008-10-16 23:22:41 EDT

Done.

Comment 11 David Green

2008-10-17 00:35:17 EDT

(In reply to comment #7)
> I have moved the extension point and merged the code from the extensible task
> ... snip ....
> available for all repositories and WikiText already works JIRA and Trac!

Nice work!