Bug 241505

Summary:

dNew Library Plug-in wizard should allow to set a BREE

Product:

[Eclipse Project] PDE

Reporter:

Benjamin Cabé <contact>

Component:

Assignee:

Jakub Jurkiewicz <jakub.jurkiewicz>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

caniszczyk, curtis.windatt.public, jakub.jurkiewicz

Version:

3.4

Keywords:

bugday

Target Milestone:

3.5 M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
mylyn/context/zip	none
Patch	caniszczyk: iplog+

Description Benjamin Cabé

2008-07-21 04:44:36 EDT

At the moment, when creating a plug-in from library, the user is not asked for a BREE.
It results in a warning in the generated bundle because of no BREE set.
We should consider fixing it for 3.4.1.

Comment 1 Benjamin Cabé

2008-07-21 04:47:14 EDT

attaching a context for bugday

Comment 2 Benjamin Cabé

2008-07-21 04:47:56 EDT

context attachment didn't work...?

Comment 3 Benjamin Cabé

2008-07-21 04:48:00 EDT

Created attachment 107904 [details]
mylyn/context/zip

Comment 4 Jakub Jurkiewicz

2008-07-24 10:32:24 EDT

Created attachment 108352 [details]
Patch

It's close to the BugDay, so I ave tried to prepare a patch. 
Most of the code is taken from org.eclipse.pde.internal.ui.wizards.plugin.PluginContentPage, so I wonder if maybe this class and org.eclipse.pde.internal.ui.wizards.plugin.NewLibraryPluginCreationPage could be refactored to reuse some parts of the code?

Comment 5 Chris Aniszczyk

2008-07-24 10:35:37 EDT

bonus points if you can find a way to refactor this code for the PDE wizards ;)

Comment 6 Jakub Jurkiewicz

2008-07-24 11:40:03 EDT

It's not so easy as I thought at the beginning ;)
I thought that maybe we could extract some super class, but now I see that it is rather impossible. The only possible solution I can see now is to create some extra class which will handle some of the common code, but I'm afraid it could lead to more complicated code. If you have any suggestion I would be happy to hear it and try to refactore this.

Comment 7 Chris Aniszczyk

2008-08-03 17:19:43 EDT

thanks.

> 20080803

Comment 8 Chris Aniszczyk

2008-08-03 17:19:53 EDT

done.