Bug 241074

Summary:

[templates] HelloRCP template contains non-externalized strings

Product:

[Eclipse Project] PDE

Reporter:

Peter Friese <peter>

Component:

Assignee:

Benjamin Cabé <contact>

Status:

RESOLVED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

caniszczyk, contact

Version:

3.5

Keywords:

bugday

Target Milestone:

3.6 M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	contact: iplog+
mylyn/context/zip	none

Description Peter Friese

2008-07-16 07:52:09 EDT

I20080715-1015

Steps to reproduce:
1) Create a new RCP project using the HelloRCP template
2) Ensure non-externalized strings are errors
3) You get errors for
   - hellorcp.ApplicationWorkbenchWindowAdvisor.preWindowOpen()
   - hellorcp.ApplicationWorkbenchAdvisor.PERSPECTIVE_ID
   - hellorcp.Activator.PLUGIN_ID
   
Those strings should probably ba marked //$NON-NLS-1$

Comment 1 Peter Friese

2008-07-16 08:12:11 EDT

Created attachment 107594 [details]
Patch

Added //$NON-NLS-1$ markers.

Comment 2 Peter Friese

2008-07-16 08:12:14 EDT

Created attachment 107595 [details]
mylyn/context/zip

Comment 3 Benjamin Cabé

2009-07-29 03:55:27 EDT

available in HEAD > 20090729

Thanks Peter!