Bug 236814

Summary:

[jsr199] EclipseCompiler#getTask does not respect its contract when its first argument is null

Product:

[Eclipse Project] JDT

Reporter:

Maxime Daniel <maxime_daniel>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jarthana, jerome_lanneluc, kent_johnson, Olivier_Thomann

Version:

3.4

Flags:

Olivier_Thomann: review-

Target Milestone:

3.6 M6

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
Suggested fix + test case	none

Description Maxime Daniel

2008-06-12 05:16:19 EDT

I20080609-1311

JavaCompiler#getTask javadoc reads:
     * @param out a Writer for additional output from the compiler;
     * use {@code System.err} if {@code null}
EclipseCompiler#getTask uses System.out instead.

Added inactive CompilerInvocationTest#22.

Comment 1 Maxime Daniel

2008-06-12 06:45:14 EDT

Created attachment 104649 [details]
Suggested fix + test case

Comment 2 Maxime Daniel

2008-06-12 06:45:48 EDT

Kent, pls let me know what you think.

Comment 3 Kent Johnson

2008-06-12 10:03:52 EDT

Isn't the JavaDoc wrong ?

I would think the default setting would be System.out when the param is null.

Comment 4 Jerome Lanneluc

2009-04-28 11:33:24 EDT

Not for 3.5

Comment 5 Olivier Thomann

2010-02-12 15:31:35 EST

Released for 3.6M6.
Might be a typo in the javadoc, but the getTask(..) doesn't allow to provide a standtard output and a standard error streams.

Comment 6 Jay Arthanareeswaran

2010-03-09 01:11:11 EST

Verified for 3.6M6 by code verification.