Summary: | Include commit set details in patch files | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Brock Janiczak <brockj> |
Component: | CVS | Assignee: | platform-cvs-inbox <platform-cvs-inbox> |
Status: | ASSIGNED --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | Michael.Valenta, Szymon.Brandys, tomasz.zarna |
Version: | 3.4 | Keywords: | helpwanted |
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: |
Description
Brock Janiczak
2008-06-11 06:46:04 EDT
The complicating factor here is that the Apply Patch wizard in Eclipse is provided by the Compare plug-in which knows nothing about commit sets. So, while it would be fairly straightforward to add an additional header line, we don't have anything in place that would allow CVS to interpret it when the patch was applied. (In reply to comment #1) True, but I agree with Brock that a patch comment would be useful. You could start with displaying it while applying the patch. I know it's not exactly what you want to achieve, but I guess it would be a good start. (In reply to comment #2) > (In reply to comment #1) > > True, but I agree with Brock that a patch comment would be useful. What I usually do is using the patch file name to keep such information. However I agree with Tomasz. Would we be able to create a change set using this information? The Compare plug-in cannot create a change set because it is below team in the architecture (i.e. Team depends on Compare). The best approach to solving this that I can see is to somehow allow repository providers to override the Apply Patch action when the selection contains projects mapped to the repository provider. Perhaps we can use the new Commands story to accomplish this properly. Then, you could write a CVS specific Apply Patch wizard that has all the knowledge required to parse the additional header info and create a change set. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |