Bug 231130

Summary:

[spec] IClassFile.getPath() not specified for external class folders

Product:

[Eclipse Project] JDT

Reporter:

Martin Aeschlimann <martinae>

Component:

Core

Assignee:

Jerome Lanneluc <jerome_lanneluc>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

benno.baumgartner, Olivier_Thomann

Version:

3.4

Target Milestone:

3.5 M1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none
New proposed fix	none

Description Martin Aeschlimann

2008-05-08 09:50:16 EDT

3.4 M7

The spec of IJavaElement.getPath says:
  * Returns the path to the innermost resource enclosing this element.
  * If this element is not included in an external library,
  * the path returned is the full, absolute path to the underlying resource,
  * relative to the workbench.
  * If this element is included in an external library,
  * the path returned is the absolute path to the archive in the file system.

It doesn't spec what to expect for class files in external folders.

Comment 1 Jerome Lanneluc

2008-06-16 11:51:44 EDT

Created attachment 105037 [details]
Proposed fix

Comment 2 Martin Aeschlimann

2008-06-16 13:12:55 EDT

I would suggest to not say 'ZIP archive', but just 'archive'. And there's a typo: Repetition of 'or'. 

+	 * the path returned is the absolute path to the archive or the 
+	 * folder in the file system.

Comment 3 Jerome Lanneluc

2008-06-17 10:49:10 EDT

Created attachment 105171 [details]
New proposed fix

Thanks Martin. The new proposed fix takes your comment into account.

Comment 4 Jerome Lanneluc

2008-06-25 07:17:33 EDT

Change released for 3.5M1

Comment 5 Olivier Thomann

2008-08-06 13:56:45 EDT

Verified for 3.5M1 using I20080805-1307