Bugzilla – Full Text Bug Listing
| Summary: | [formatter] New comment formatter does not handle properly all scanner exceptions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Frederic Fusier <frederic_fusier> | ||||
| Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, eric_jodet, jerome_lanneluc | ||||
| Version: | 3.4 | Flags: | jerome_lanneluc:
review+
|
||||
| Target Milestone: | 3.4 RC1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
This is due to the fact that the Scribe scan the line using the Scanner getNextToken() method for optimization reason. The scanner raises an exception on the first word which is not properly handled while printing the comment line. Currently only string and character exceptions are properly handled, but they all should be. Created attachment 98655 [details] Proposed patch Note that this patch also fixes following bugs bundle: - bug 229682 - bug 229683 - bug 229932 - bug 229954 - bug 230184 With this patch, we got 5 failures in Eclipse 3.0 full source workspace and 21 in Ganymede M6a one. Jerome can you please review? Released for 3.4RC1 in HEAD stream. Verified for 3.4RC1 using build I20080510-2000. |
Using build 3.4M7 The new comment formatter does not format properly the following simple test case: public class X { void foo() { // 1EX5I8Z - accessing outer fields within a constructor call } } The output currently is: public class X10 { void foo() { // EX5I8Z - accessing outer fields within a constructor call } } Note that the '1' at the comment beginning has been removed.