Bug 229479

Summary: [rseterminal][api] terminals.core should not force load terminals.ui
Product: [Tools] Target Management Reporter: Martin Oberhuber <mober.at+eclipse>
Component: RSEAssignee: Anna Dushistova <anna.dushistova>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: enhancement    
Priority: P3 CC: dmcknigh, francescocriv, gpapayia, torkildr, wb-rel, xuanchen, ykuo
Version: 3.0Keywords: api, contributed
Target Milestone: 3.0 M7   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 226764    
Bug Blocks:    
Attachments:
Description Flags
patch that removes forced load of UI plug-in from core one. mober.at+eclipse: iplog+

Description Martin Oberhuber CLA 2008-04-29 16:52:11 EDT 
org.eclipse.rse.subsystems.terminals.core/Activator.java currently contains some code to force load the UI part.

This is not a good idea since (a) the subsystem might be used in a headless non-UI envrionment eventually, and (b) the UI plugin should be loaded lazily.

Consider bug 218304 which got rid of the force loading of adapters as a blueprint for how it should be done (i.e. when the UI plugin should be loaded lazily).
Comment 1 Martin Oberhuber CLA 2008-04-29 16:53:05 EDT 
Note that I consider this API since clients might expect the UI plugin to be available at a given time, so the fact of loading it lazily is - to some extent - an API change.
Comment 2 Anna Dushistova CLA 2008-05-02 13:25:17 EDT 
Created attachment 98468 [details]
patch that removes forced load of UI plug-in from core one.

I, Anna Dushistova, declare that I developed attached code from scratch,
without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
Comment 3 Martin Oberhuber CLA 2008-05-02 18:52:12 EDT 
Patch applied, 2 added and 16 removed lines.

Anna, did you test everything, e.g. does the terminal work as expected for you? Or did you find any problems such as missing icons or NullPointerException in special cases?
Comment 4 Anna Dushistova CLA 2008-05-03 03:50:10 EDT 
> Anna, did you test everything, e.g. does the terminal work as expected for you?

Yes, I tested it and it worked fine for me.

> Or did you find any problems such as missing icons or NullPointerException in
> special cases?

No, I haven't seen any.