Summary: | BIDI: Enhance TextProcessor to support "Messages with placeholders" types of complex expressions | ||
---|---|---|---|
Product: | [Eclipse Project] Equinox | Reporter: | Tomer Mahlin <tomerm> |
Component: | Components | Assignee: | equinox.components-inbox <equinox.components-inbox> |
Status: | ASSIGNED --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | benno.baumgartner, daniel_megert, eclipse.felipe, Lina.Kemmel, mahag, markus.kell.r, martinae, matial, mfadl, pwebster, sadir, tjwatson, Tod_Creasey |
Version: | 3.4 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | All | ||
Whiteboard: | |||
Bug Depends on: | 466345, 183164 | ||
Bug Blocks: | 222889, 224921 |
Description
Tomer Mahlin
2008-04-27 09:08:38 EDT
Moving to Maybe the original owner (Tod?) can take a look? We won't be doing this in 3.4 as we are feature frozen Tod, would you be able to look into this in 3.5? CC'ing Felipe for BIDI help. Felipe could you provide some help/review of this (not for 3.4). I just wanted to correct a mistake made in the "The solution - design" section. In the following paragraph you can see that item b is identical to item a: a. To enforce LTR direction: myText = LRE + LRM + myText + LRM + PDF b. To enforce LTR direction: myText = LRE + LRM + myText + LRM + PDF While item a describes a solution for enforcement of LTR direction, item b was supposed to describe a solution for RTL direction enforcement. Thus the correct version of those items is as follows: a. To enforce LTR direction: myText = LRE + LRM + myText + LRM + PDF b. To enforce RTL direction: myText = RLE + RLM + myText + RLM + PDF I appreciate very much the feedback I got from Mati who first spotted the mistake above. Not going to do anything here for 3.5. I think any such enhancements should be done in the proposal in bug 183164 which is a layer above the framework (org.eclipse.equinox.bidi or something like that). It is a mistake to keep tacking things into the core framework for this. I agree. Indeed the proposal for bug 183164 has basic capability to enforce base text direction. I think we still need a utility function to make the usage convenient for "Messages with placeholders" case. I will add a comment on this to bug 183164. Moving to components since this will likely be build upon the bundle coming out of bug 183164. bug183164 is not targeting 3.7, so I am dropping the milestone of this dependent bug. |