Bug 228783

Summary: Mapping File wizard: no error given for an invalid source folder path
Product: [WebTools] Dali JPA Tools Reporter: Paul Fullbright <paul.fullbright>
Component: GeneralAssignee: Paul Fullbright <paul.fullbright>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: karenfbutzke, muko, neil.hauge
Version: 2.0Flags: neil.hauge: review+
Target Milestone: 2.0.1   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
proposed patch none

Description Paul Fullbright CLA 2008-04-24 17:54:08 EDT 
If a source folder path is selected that can't possibly be created (such as "/NonexistentProject"), there is no error.

There is also no error if the source folder is actually in a different project.
Comment 1 Paul Fullbright CLA 2008-04-29 11:21:35 EDT 
Fix committed to head.
Comment 2 Karen Butzke CLA 2008-06-04 14:03:17 EDT 
same problem as bug 228781:

There is a warning now, but the Finish button is enabled.  Probably needs to be
an error and the Finish button disabled.  If you press finish several
exceptions get thrown:

java.lang.NullPointerException
at
org.eclipse.jpt.core.internal.operations.OrmFileCreationOperation.createOrmXml(OrmFileCreationOperation.java:130)
at
org.eclipse.jpt.core.internal.operations.OrmFileCreationOperation.execute(OrmFileCreationOperation.java:54)
at
org.eclipse.wst.common.frameworks.internal.datamodel.DataModelPausibleOperationImpl$1.run(DataModelPausibleOperationImpl.java:376)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1800)


org.eclipse.ui.PartInitException: Unable to open external editor for
C:/MyTestWorkspace/TestProject/srct/META-INF/orm.xml.
at
org.eclipse.ui.internal.EditorManager.openSystemExternalEditor(EditorManager.java:880)
at
org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:663)
at org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:639)
Comment 3 Paul Fullbright CLA 2008-07-21 15:06:50 EDT 
Created attachment 107987 [details]
proposed patch

Same patch as for bug 228781.  Simply changing two warning cases to error
cases.
Comment 4 Paul Fullbright CLA 2008-07-22 17:52:04 EDT 
Committed patch to maintenance branch and head.
Comment 5 Neil Hauge CLA 2008-08-21 17:48:10 EDT 
Verified in wtp-sdk-R-3.0.1-20080818032401.
Comment 6 Neil Hauge CLA 2008-09-17 14:16:33 EDT 
*** Bug 247111 has been marked as a duplicate of this bug. ***