Summary: | AST: no binding for Javadoc reference to inner class | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Martin Aeschlimann <martinae> | ||||
Component: | Core | Assignee: | Eric Jodet <eric_jodet> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | frederic_fusier, jerome_lanneluc, Konstantin.Scheglov, Olivier_Thomann | ||||
Version: | 3.4 | Flags: | eric_jodet:
review+
eric_jodet: review+ |
||||
Target Milestone: | 3.4 RC2 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Martin Aeschlimann
2008-04-24 07:19:56 EDT
Inner' in '#foo(Inner)' node has no binding as soon as compliance is 1.4. Bindings are ok for compliance > 1.4 bug introduced at 3.4 M3 while fixing bug 195374 Created attachment 101038 [details]
[proposed patch + test case] on top v865
(In reply to comment #2) with this fix: - still report the unresolved reference at 1.4 compliance as requested by bug 195374 - resolve the bindings (In reply to comment #2) passes all jdt.core, ui and text tests Since this is a regression comparing to 3.3.2, and the patch is quite simple, we should target it for 3.4RC2. Eric, please ask for the reviews of the patch. Frederic, may you please review proposed correction? thanks (In reply to comment #6) Jerome, may you also please review? thanks Patch looks good: +1 However, while reviewing the patch, I discovered a problem on the fix released for the initial bug 195374. The types partially qualified are warned by the javadoc tool but not by the JDT compiler. I have opened bug 233187 for this issue... Patch looks good: +1 patch released in HEAD for 3.4RC2 (refresh issue) Verified for 3.4RC2 using I20080523-0100. |