Bug 225162

Summary:

Bugs with new pinnable palette stacks

Product:

[Tools] GEF

Reporter:

Cherie Revells <crevells>

Component:

GEF-Legacy GEF (MVC)

Assignee:

Cherie Revells <crevells>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

ahunter.eclipse

Version:

3.4

Keywords:

accessibility, contributed

Target Milestone:

3.4.0 (Ganymede) M7

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Bug fixes	ahunter.eclipse: iplog+

Description Cherie Revells

2008-04-01 13:35:38 EDT

- keyboard accessibility does not work with pinnable stacks
- pin figure needs to be centered a bit better
- the outline of the stack figure has a funny line bend when expanding last or
first stack in row -- noticable most in columns layout mode.

Comment 1 Cherie Revells

2008-04-04 11:17:29 EDT

Created attachment 94865 [details]
Bug fixes

Fixes for the following issues:
- Fixed keyboard accessibility for palette stacks by making changes to PaletteViewerKeyHandler.
- Modified the PinDrawerAction to work on all pinnable palette editparts including stacks (allowing keyboard accessibility for pinning stacks).
- Moved pin slightly to the left so it lines up with the drawer's pin.
- Fixed funny line bend when expanding last or first stack in row (in columns and icons layout mode).
- The active tool title in a stack no longer shows behind the pin.

Anthony, this one is ready for review.  I added a new public interface:  IPinnableEditPart.  If it is not ok to add this interface at this point, I can rework the code a bit.

Comment 2 Anthony Hunter

2008-04-07 16:42:27 EDT

Committed to HEAD