Summary: | [ui] when sizing discovers artifacts missing, report to the user before trying to install | ||
---|---|---|---|
Product: | [Eclipse Project] Equinox | Reporter: | Jeff McAffer <jeffmcaffer> |
Component: | p2 | Assignee: | P2 Inbox <equinox.p2-inbox> |
Status: | RESOLVED WONTFIX | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | Ed.Merks, matthew, pascal, susan |
Version: | unspecified | Keywords: | helpwanted, usability |
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows Vista | ||
Whiteboard: | |||
Bug Depends on: | 212811 | ||
Bug Blocks: |
Description
Jeff McAffer
2008-03-10 18:41:17 EDT
Marking as a dependent and keeping open to discuss the UI improvments renaming so it's clear this is not just an error message issue. Given the set of bugs left for 3.5 I don't think this will happen without a contribution. In the end this would be a nice usability improvement, but since sizing happens in the background and often doesn't finish before the user hits Finish, it won't always help. Just a note that the Sizing phase does return a status code when it is unable to find artifacts or when the repository doesn't provide size information. Rereading the original comment: - nothing to install and 0 install size. Not clear if there were items listed in the install details page and a 0 size, or no items in the list at all. We had bugs in 3.4 where some resolutions would advance in the wizard and there was nothing listed to install. That doesn't happen anymore. - if there was stuff listed and size was 0, then a size of 0 was computed. Given Matt's work in bug 212811, we now say size is "Unknown" if an artifact was found missing. Before we reported the partial size. In 3.5, we are better off than when originally reported, because you would have never gotten to the details page if there was truly nothing to be installed, and if there was something to install ,you'd see the list (and drilldown) of everything to be installed, and either a size or "Unknown." So the problem of "I never pushed finish because it didn't look like there was anything to install" shouldn't happen anymore. The question remaining in this bug is whether it's valuable to report a missing artifact when discovered during sizing. The wizard reports errors that are detected prior to resolution (such as locked IU's) or during resolution (things the planner reported). Normally, those errors found later (missing artifact, signature verification issue, etc.) are reported as they are found. It's not clear what a good workflow would be. We wouldn't want to randomly move the user back to the error page when the sizing finished. We could report something underneath the sizing info "some stuff is missing, the install is probably not going to work" but disabling finish asynchronously seems harsh. I agree with John that it's not going to happen for 3.5. Given the amount of times users encounter missing artifact errors (site is not refreshed, the lost artifact repo bug, etc), I think it'd be better to put effort toward handling that error more gracefully and suggesting quickfixes. Right now we say "error during collect phase...blah blah blah" and it would be better to state more clearly what is missing and present possible fixes (refresh the repo that is likely to contain it, etc.) This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This is relative to a UI that I don't see used today. |