Bug 219852

Summary:

[refactoring] changing plugin.properties should update Bundle-Localization

Product:

[Eclipse Project] PDE

Reporter:

Chris Aniszczyk <caniszczyk>

Component:

Assignee:

Benjamin Cabé <contact>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

contact, tjwatson

Version:

3.4

Keywords:

bugday, contributed

Target Milestone:

3.4 M6

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed patch	none
mylyn/context/zip	none
Updated patch adding move support	none
Copyrights update	none

Description Chris Aniszczyk

2008-02-21 14:54:23 EST

1) refactor plugin.properties to bundle.properties
2) notice how Bundle-Localization isn't updated :(

Comment 1 Benjamin Cabé

2008-02-23 08:21:57 EST

Created attachment 90544 [details]
Proposed patch

If renamed from a.properties to b.properties, Bundle-Localization header is updated from a to b
If renamed from a.properties to b.foo, Bundle-Localization header is removed

Comment 2 Benjamin Cabé

2008-02-23 08:22:01 EST

Created attachment 90545 [details]
mylyn/context/zip

Comment 3 Chris Aniszczyk

2008-02-23 12:44:53 EST

Almost there Ben :)

I found one case where if you Refactor->Move the file into another directory, say icons, the MANIFEST.MF isn't properly updated with Bundle-Localization: icons/plugin

Comment 4 Benjamin Cabé

2008-02-23 12:49:27 EST

Yap, nice catch!
In fact I just thought the file couldn't be elsewhere than in the root directory

Comment 5 Benjamin Cabé

2008-02-23 18:17:04 EST

Created attachment 90563 [details]
Updated patch adding move support

Comment 6 Benjamin Cabé

2008-02-23 18:25:17 EST

see bug 220085

Comment 7 Benjamin Cabé

2008-02-25 03:22:00 EST

Created attachment 90604 [details]
Copyrights update

Comment 8 Chris Aniszczyk

2008-02-25 11:29:25 EST

Thanks Benjamin! Looks good. I made some minor modifications to catch more places that we weren't using values out of ICoreConstants when we should have been.

Thanks!