Bug 212745

Summary:

Wording and wrong title case in dialog that warns when importing while running a target

Product:

[Eclipse Project] PDE

Reporter:

Dani Megert <daniel_megert>

Component:

Assignee:

bartosz michalik <bartosz.michalik>

Status:

RESOLVED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

baumanbr

Version:

3.4

Keywords:

contributed

Target Milestone:

3.4 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
simple fix	none

Description Dani Megert

2007-12-12 09:11:17 EST

I20071212-0010.

See bug 185502 for details.

The dialog that's now shown has three issues:
- it should be a warning dialog
- dialogs should use title casing i.e. start words with big letters
- it says: ... plug-ins my not be... (my -> may)
- the message talks about 'workbench' but actually it can be anything that
  runs eclipse code (e.g. a simple SWT app).

How about this:

title:
  Running Application

message:
   An application is currently running. Some of the selected plug-ins may not be imported if they are locked by it. Do you want to continue?

If more than one app is running it has to be changed to:

title:
  Running Applications

message:
   Applications are currently running. Some of the selected plug-ins may not be imported if they are locked by one of them. Do you want to continue?

Comment 1 Brian Bauman

2007-12-12 12:07:35 EST

Bartosz volunteered to take this one.

Comment 2 bartosz michalik

2007-12-12 12:40:11 EST

Created attachment 85093 [details]
simple fix

Comment 3 Brian Bauman

2007-12-12 15:49:55 EST

Thanks Bartosz for the quick fix.  The patch was applied as is and made it into I20071212-1300.

Comment 4 Dani Megert

2007-12-13 03:45:12 EST

Looked at the fix in I20071212-1800: this is a good improvement and good enough for M4 but a UI guideline in eclipse is to use singular and plural correctly i.e. you have to check whether there is 0, 1 or more apps running and show the appropriate message.

You should either reopen this bug and target for M5 or file a new one.

Comment 5 Brian Bauman

2008-01-11 14:59:59 EST

Dani, I will take your word for it about the singular/plural rule because I did not find it on the Eclipse UI Guidelines wiki :)

The messages should be updated in HEAD now to reflect one vs. multiple runtimes.

Comment 6 Dani Megert

2008-01-14 05:32:28 EST

Thanks.