Bug 209709

Summary: CompositeTransactionalCommand#reduce should flatten child commands if !isTransactionNestingEnabled()
Product: [Modeling] GMF-Runtime Reporter: Christian Vogt <cvogt>
Component: GeneralAssignee: Alex Boyko <aboyko>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse
Version: 2.0.1Keywords: contributed
Target Milestone: 2.0.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch for CompositeTransactionalCommand none

Description Christian Vogt CLA 2007-11-13 16:27:57 EST
Created attachment 82806 [details]
patch for CompositeTransactionalCommand

I have attached a patch for the CompositeTransactionalCommand which adds some logic to the reduce() method which will flatten out the child commands recursively if !isTransactionNestingEnabled(). Flattening large command structures prior to executing yields good performance improvements.
Comment 1 Anthony Hunter CLA 2007-11-16 10:41:44 EST
Hi Alex, can you review and commit to R2_0_maintenance if acceptable?
Comment 2 Alex Boyko CLA 2007-11-21 16:22:21 EST
Committed the patch to R2_0_maintenance and HEAD
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:24:48 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime EMF was the original product and component for this bug