Bug 208234

Summary:

Specify that CodeFormatter is not intended to be subclassed

Product:

[Eclipse Project] JDT

Reporter:

Jerome Lanneluc <jerome_lanneluc>

Component:

Core

Assignee:

Eric Jodet <eric_jodet>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

david_audel, jerome_lanneluc

Version:

3.4

Target Milestone:

3.4 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
[patch] - proposed correction	none

Description Jerome Lanneluc

2007-10-31 10:48:31 EDT

I20071031-0010

org.eclipse.jdt.core.formatter.CodeFormatter doesn't specify whether can subclass it or not. However, the intent was never to allow clients to subclass it. Clients can only obtain a new CodeFormatter using ToolFactory#createCodeFormatter(...).

We should add the following to the Javadoc:

 * <p>
 * This class is not intended to be instantiated or subclassed by clients.
 * </p>

Comment 1 Jerome Lanneluc

2007-10-31 10:49:18 EDT

Eric, please make the change for 3.4M4.

Comment 2 Eric Jodet

2007-11-07 07:51:28 EST

Created attachment 82317 [details]
[patch] - proposed correction

(In reply to comment #1) - contains the modified javadoc

Comment 3 Eric Jodet

2007-11-07 07:54:11 EST

Patch released for 3.4M4 in HEAD.

Comment 4 Eric Jodet

2007-11-07 07:56:02 EST

Fixed in HEAD

Comment 5 David Audel

2007-12-11 07:43:48 EST

Verified for 3.4M4 using build I20071210-1800.