Summary: | [BiDi] BIDI_HCG: Wrong display of paths in Save Resources dialog | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Tomer Mahlin <tomerm> | ||||
Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
Status: | NEW --- | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | ob1.eclipse, semion | ||||
Version: | 3.4 | ||||||
Target Milestone: | --- | ||||||
Hardware: | PC | ||||||
OS: | Windows 2000 | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Tomer Mahlin
2007-10-17 05:43:17 EDT
Created attachment 146174 [details]
Patch with suggested changes
This label provider code is run for all types of parts. Editors return either the value from their input.getToolTipText() or whatever is set on the part. Views return the value set on their part. The only case where we know it is a file is if we're dealing with a FileEditorInput and potentially a FileStoreEditorInput ... a client defined input might not have path semantics (if it represents a model, for example). We need to consider this with our fix. PW (In reply to comment #2) It seems that this might be better solved as a part of some generic BiDi enhancement. In this bug APIs give us Strings and we don't know what semantic information they represent. Semion, Tomer, is there a subsclass of String that would carry with it extra semantic information for the TextProcessor? You read our minds. Indeed it is necessary to pass somehow this semantic information to the right context. The context reported in this defect is not the only one in which this is required (another context is Problems view which displays compilation errors and shows file paths). Unfortunately the resolution is not going to come from JDK (I believe String can't be directly extended) and JDK now is part of Oracle ... So, I guess we will have to find a different solution. By copy to Semion, do you have any suggestions ? This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |