Bug 203894

Summary: Allow connections styles to change after connections have been created
Product: [Tools] GEF Reporter: Ian Bull <irbull>
Component: GEF-Legacy ZestAssignee: gef-inbox <gef-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: ugorox
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Ian Bull CLA 2007-09-18 17:22:58 EDT
Zest connections styles should be changeable after the connections have been created.  Opening to investigate.
Comment 1 Ugo Sangiorgi CLA 2007-10-18 18:44:30 EDT
Actually, there is an explicit condition on AbstractStructuredGraphViewer, if there is an input, a error is thrown. 
If i just comment the line, nothing else is affected, the graph viewer works perfectly fine and the connection style is really changed, it just works.

public void setConnectionStyle(int connectionStyle) {
		if (getInput() != null) {
		 //ZestException.throwError(ZestException.ERROR_CANNOT_SET_STYLE, "", null);
		}
		if (!ZestStyles.validateConnectionStyle(connectionStyle)) {
			ZestException.throwError(ZestException.ERROR_INVALID_STYLE, "", null);
		}
		this.connectionStyle = connectionStyle;
	}

Why exactly one cannot set the style after the graph is already set?
Comment 2 Alexander Nyßen CLA 2015-01-22 02:44:50 EST
Re-assigning back to inbox, as Ian is no longer active committer.