Bug 203124

Summary:

rse.doc.isv contains lot of html errors (HEAD version)

Product:

[Tools] Target Management

Reporter:

Olivier Thomann <Olivier_Thomann>

Component:

RSE

Assignee:

Martin Oberhuber <mober.at+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

Keywords:

contributed

Version:

unspecified

Target Milestone:

2.0.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none
Proposed fix	mober.at+eclipse: iplog+

Description Olivier Thomann

2007-09-12 14:54:50 EDT

I got lot of indexing errors with version 1.0.1 of the rse.doc.user plugin. So I downloaded the rse.doc.isv and rse.doc.user plugins and I found lot of html errors in the code from HEAD.
I'll attach a patch that is fixing most of the problems.

Comment 1 Olivier Thomann

2007-09-12 14:55:18 EDT

Created attachment 78222 [details]
Proposed fix

Comment 2 Martin Oberhuber

2007-09-12 15:08:12 EDT

Awsome! Patch applied.

Your patch looks like 650 lines of change, but that's mostly due to CRLF / LF differences. In the Synchronize View, it was only 40 lines of change.

guide/tutorial/index.html was not matched when I applied the patch. What was your intention with that one? Could you check again on the updated HEAD?

Comment 3 Olivier Thomann

2007-09-12 15:50:34 EDT

I'll double-check the contents of HEAD later today.

Comment 4 Olivier Thomann

2007-09-12 17:18:03 EDT

Everything seems fine now except the index.html file in the guide/tutorial section. It is supposed to be a text file so CVS should convert the line delimiter on checkout.
However it seems that it contains unix line separators.
I will attach a patch that converts the line delimiter to DOS line delimiter on windows.

Comment 5 Olivier Thomann

2007-09-12 17:18:28 EDT

Created attachment 78234 [details]
Proposed fix

Comment 6 Martin Oberhuber

2007-09-12 17:28:56 EDT

Ha, that's funny. The file was marked ASCII -kkv in CVS, but it had Mac line endings (\r\r). I was unable to apply your patch on Windows, but I think I fixed it. Could you verify?

Comment 7 Olivier Thomann

2007-09-12 17:53:22 EDT

Yes, it looks ok.
Thanks for fixing this so quickly.