Summary: | No banner graphics in Save As dialog (1GDKM9Y) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Simon Arsenault <simon_arsenault> | ||||||||||
Component: | UI | Assignee: | Randy Giffen <Randy_Giffen> | ||||||||||
Status: | RESOLVED FIXED | QA Contact: | |||||||||||
Severity: | normal | ||||||||||||
Priority: | P3 | CC: | lynne_kues | ||||||||||
Version: | 2.0 | ||||||||||||
Target Milestone: | --- | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Whiteboard: | |||||||||||||
Attachments: |
|
Description
Simon Arsenault
2001-10-10 22:24:45 EDT
PRODUCT VERSION: 0.105 Created attachment 210 [details]
picture of Save As dialog
Created attachment of Save As dialog. Inconsistencies as follows: - dialog has a banner gif without an icon ==> use same gif as for create new file - dialog uses "..." in it's titles ==> get rid of ... in labels - dialog does not have explanation text like other wizards ==> add an explanation Created attachment 212 [details]
patch file
Patch file doesn't appear to pick up new resource files. Including new image files as attachments. These files go under /icons/full/wizban and /icons/basic/wizban. Created attachment 215 [details]
full image file
Created attachment 216 [details]
basic image file
Waiting on RG to review. Reassigning to him. Reviewed and released the changes I made the following change to the method comment in SelectionDialog to follow the JavaDoc pattern we use when overriding methods. /** * The <code>SaveAsDialog</code> iplementation of this <code>Window</code> * method disposes of the banner image when the dialog is closed. */ public boolean close() { if (dlgTitleImage != null) dlgTitleImage.dispose(); return super.close(); } |