Summary: | [templates] template context names should not be all lowercase | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Dani Megert <daniel_megert> | ||||
Component: | Text | Assignee: | JDT-Text-Inbox <jdt-text-inbox> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | minor | ||||||
Priority: | P3 | CC: | dakshinamurthy.karra | ||||
Version: | 3.3 | ||||||
Target Milestone: | 3.4 M2 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Dani Megert
2007-09-05 04:09:03 EDT
Adding to this, can we also use different strings for Ids and names? Though it does not cause problems, using fully qualified name for an id is recommended. From TemplateContextType Java Doc: * Creates a context type with an identifier. The identifier must be unique, a qualified name is suggested. Unfortunately we can't change that now as the ID is in the plugin.xml and hence can be used/referenced by others who contribute templates to it. Created attachment 78065 [details]
proposed fix
This fixes the issue by calling the default constructor in TemplateContextType which is allowed for subclass constructors.
Thanks Benno! Fixed in HEAD. Available in builds >= N20070912-0010. |