Bug 201867

Summary: [terminal-ssh] Add port to SSH connection summary string
Product: [Tools] Target Management Reporter: Mikhail Kalugin <mikhail.kalugin>
Component: TerminalAssignee: Martin Oberhuber <mober.at+eclipse>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: minor    
Priority: P4 CC: andrei.sobolev
Version: 2.0Keywords: contributed
Target Milestone: 2.0.1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch for SshConnectorInfo mober.at+eclipse: iplog+

Description Mikhail Kalugin CLA 2007-08-31 04:26:41 EDT
Created attachment 77444 [details]
Patch for SshConnectorInfo

Now SSH connection summary string has form <host>:<user>. I think that <user>@<host>:<port> would be better presentation for connection info. It has more popular syntax and contains more information. Does anybody has any objection about it? 

The patch that fixes string is attached.
Comment 1 Martin Oberhuber CLA 2007-09-03 11:20:39 EDT
Patch applied with slight modification - adding the "port" only if it's not the default (22). Thanks!
Comment 2 Martin Oberhuber CLA 2007-09-03 14:02:40 EDT
BTW, when submitting another patch you would make us the work slightly easier if you could please

1. Add a line in the file header comment for your contribution, such that it is
   shipped with the patch. This time, I added the following for you:

 * Mikhail Kalugin <fourdman@xored.com> - [201867] Improve Terminal SSH connection summary string

2. Provide your patch as an "Eclipse Workspace Patch" (created with Team > 
   Create Patch...) -- this way I don't have to look for the right project

3. Add the disclaimer in the bugzilla comment as outlined here:
   http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib

Thanks!