Bug 201572

Summary:

[Manifest][Editors] Package Friends are not selected after addition

Product:

[Eclipse Project] PDE

Reporter:

Noam Chitayat <noam.chitayat>

Component:

Assignee:

Benjamin Cabé <contact>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

caniszczyk, contact

Version:

3.3

Keywords:

contributed

Target Milestone:

3.4 M6

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed patch to fix this bug	none
mylyn/context/zip	none
Updated patch	none
mylyn/context/zip	none
org.eclipse.pde.ui.patch	none
mylyn/context/zip	none

Description Noam Chitayat

2007-08-29 10:26:28 EDT

1. Create a new Plug-in Project or open an existing one with exported packages.

2. Select a package that is either internal or visible. (It must have been that way before you opened the manifest editor)

3. In the Package Visibility section on the top-right, ensure that the "hidden from all plug-ins except" radio button is selected.

4. Click "Add..." and add a plug-in to this list.
--> Bug: The added plug-in is not selected

Comment 1 Benjamin Cabé

2008-02-12 12:44:41 EST

I'll have a look at this bug

Comment 2 Benjamin Cabé

2008-02-12 13:37:35 EST

Created attachment 89528 [details]
Proposed patch to fix this bug

Comment 3 Benjamin Cabé

2008-02-12 13:37:38 EST

Created attachment 89529 [details]
mylyn/context/zip

Comment 4 Chris Aniszczyk

2008-02-12 13:52:05 EST

It didn't work :(

Comment 5 Benjamin Cabé

2008-02-12 14:19:13 EST

Arg, I corrected another small bug occuring on windows only (exported package selected but not "focused" when added in the list), not the one described in the steps ;) !..

Comment 6 Benjamin Cabé

2008-02-12 14:35:28 EST

Created attachment 89543 [details]
Updated patch

Comment 7 Benjamin Cabé

2008-02-12 14:35:31 EST

Created attachment 89544 [details]
mylyn/context/zip

Comment 8 Chris Aniszczyk

2008-02-12 20:34:46 EST

Created attachment 89582 [details]
org.eclipse.pde.ui.patch

made a slight change in regards to setting focus, we were selecting items in the friend's viewer but not actually giving it focus so your keyboard would be useless.

Comment 9 Chris Aniszczyk

2008-02-12 20:34:52 EST

Created attachment 89583 [details]
mylyn/context/zip

Comment 10 Chris Aniszczyk

2008-02-12 20:36:06 EST

Thanks for the patch Ben! :)

Another one bites the dust!

Comment 11 Chris Aniszczyk

2008-02-12 20:36:34 EST

Another one bites the dust >:)!