Bug 201566

Summary: XMLContentAssistProcessor, ExtensionAttributePointDetector make unnecessary casts
Product: [Eclipse Project] PDE Reporter: Noam Chitayat <noam.chitayat>
Component: UIAssignee: Remy Suen <remy.suen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: caniszczyk, janek.lb, remy.suen
Version: 3.3Keywords: bugday, contributed
Target Milestone: 3.4 M2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch to remove the casts. 'Save Actions' is your friend, though. You can configure it to remove unnecessary casts, by the way. ;)
none
mylyn/context/zip none

Description Noam Chitayat CLA 2007-08-29 10:07:01 EDT 
In
org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/contentassist	XMLContentAssistProcessor.java:

Unnecessary cast from IDocumentAttributeNode to IDocumentElementNode at line 245
Unnecessary cast from IDocumentAttributeNode to IDocumentRange at line 323
Unnecessary cast from IDocumentAttributeNode to IDocumentRange at line 331
Unnecessary cast from IDocumentAttributeNode to IDocumentRange at line 421

In
org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin	ExtensionAttributePointDectector.java:

Unnecessary cast from IDocumentAttributeNode to IDocumentElementNode at line 132
Comment 1 Chris Aniszczyk CLA 2007-08-29 10:15:54 EDT 
Where's Janek :)?
Comment 2 Remy Suen CLA 2007-08-29 14:34:14 EDT 
Created attachment 77281 [details]
Patch to remove the casts. 'Save Actions' is your friend, though. You can configure it to remove unnecessary casts, by the way. ;)
Comment 3 Chris Aniszczyk CLA 2007-08-29 15:13:26 EDT 
thanks Remy :)
Comment 4 Chris Aniszczyk CLA 2007-08-29 15:13:30 EDT 
Created attachment 77288 [details]
mylyn/context/zip
Comment 5 Janek Lasocki-Biczysko CLA 2007-08-31 13:05:59 EDT 
Hehe, just noticed this now.. too late!