Bug 201066

Summary:

[prefs] Preferences listeners are not removed while shutting down JavaModelManager

Product:

[Eclipse Project] JDT

Reporter:

Frederic Fusier <frederic_fusier>

Component:

Core

Assignee:

Frederic Fusier <frederic_fusier>

Status:

VERIFIED FIXED

QA Contact:

Severity:

major

Priority:

CC:

jerome_lanneluc

Version:

3.3

Target Milestone:

3.4 M2

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch	none

Description Frederic Fusier

2007-08-24 07:14:31 EDT

While initializing JavaModelManager, preferences listeners are set but they are not removed while shutting down!

Comment 1 Frederic Fusier

2007-08-28 05:04:57 EDT

Created attachment 77102 [details]
Proposed patch

Preferences listeners are now stored in JavaModelManager to remove them while shutting down.

This patch also gives easier access to indexManager and deltaState variables through static methods instead of using getJavaModelManager()...

UserLibraryManager is also no longer a preferences listener but just called by the existing one when the modified preference name starts with user library prefix.

Comment 2 Frederic Fusier

2007-08-28 06:55:27 EDT

Released for 3.4M2 in HEAD stream.

Comment 3 Eric Jodet

2007-09-18 00:56:38 EDT

(In reply to comment #2)
Verified in the code for 3.4 M2 using build I20070917-0010.