Bug 200433

Summary:

Create servlet wizard should say 'Use existing Servlet class or JSP'

Product:

[WebTools] WTP Java EE Tools

Reporter:

Raj Mandayam <ramanday>

Component:

jst.servlet

Assignee:

Carl Anderson <ccc>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

ccc, kaloyan, thatnitind

Version:

2.0

Keywords:

contributed

Target Milestone:

3.0

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

219304

Attachments:

Description	Flags
cvs patch	none
patch that has only value changes	bjorn.freeman-benson: iplog+

Description Raj Mandayam

2007-08-17 17:52:47 EDT

Build ID: WTP 201
This is coming in response to a defect in adopter product where users cannot find a way to choose existing JSP.
Steps To Reproduce:
Create servlet wizard should say 'Use existing Servlet class or JSP'

It currently says Create servlet wizard should say 'Use existing Servlet class' and has a browse button, but if you click that you can select a servlet class or JSP and by spec you are allowed to choose either.

simple string value change required, patch attached

More information:

Comment 1 Raj Mandayam

2007-08-17 17:53:56 EDT

Created attachment 76349 [details]
cvs patch

Comment 2 Carl Anderson

2007-08-20 22:43:37 EDT

Raj,  I don't think this meets the criteria for 2.0.1... can we wait until 3.0?

Comment 3 Nitin Dahyabhai

2007-08-21 13:37:32 EDT

This change is only a UI change, and we don't generally do UI or string changes in a maintenance release.

Comment 4 Raj Mandayam

2007-08-21 14:04:08 EDT

Yes, Its a UI change and normally I would not be asking for this change, but this is really a glaring error, I dont know how it was not caught earlier by other users in WTP.

As I mentioned earlier, because the wizard says 'Use existing Servlet class' there is no way for users to know HOW they can add a JSP. And this was brought to our attention in an adopter product where it was considered to be a regression because Servlet wizards (previously versions of the adopter product) would display the option to choose a JSP more clearly (its not clear here).

Comment 5 Carl Anderson

2007-08-23 10:50:13 EDT

I discussed this with Chuck- he agrees with Nitin and myself.  This change will go into the 3.0 stream when we branch.

Also, renaming the constant that is used to retrieve the string is not a good practice- the name of the constant may not be 100% correct now, but this sort of practice can lead to all sorts of problems.  (You should just change the contents of the string in the .properties file.)  Can you simplify this patch and reattach?

Comment 6 Raj Mandayam

2007-08-23 11:14:19 EDT

Created attachment 76777 [details]
patch that has only value changes

Patch with only the property value being changed. 
Regarding the previous comment, about renaming the constant,the reason I did it was
1. its an internal constant, so nobody should be using it anyway. 
2. when name of the constant is 'use servlet' and value is 'use servlet or jsp' why not change the name of the constant to be more accurate. even though I agree just changing the value is more non-visible change and since WTP 201 is a maintenance release, so I have attached the patch.

Comment 7 Carl Anderson

2008-02-20 11:28:31 EST

Committed to HEAD

Comment 8 David Williams

2008-04-24 00:45:10 EDT

mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.