Summary: | SystemViewFilterReferenceAdapter#internalGetChildren() should not be synchronized since it could deadlock | ||||||
---|---|---|---|---|---|---|---|
Product: | [Tools] Target Management | Reporter: | Martin Oberhuber <mober.at+eclipse> | ||||
Component: | RSE | Assignee: | David McKnight <dmcknigh> | ||||
Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||
Severity: | normal | ||||||
Priority: | P2 | CC: | kjdoyle | ||||
Version: | 2.0 | Flags: | mober.at+eclipse:
review+
|
||||
Target Milestone: | 2.0.1 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Martin Oberhuber
2007-08-10 09:50:24 EDT
For similar issues, see also bug 199565 and bug 199568. See bug #199573 comment 1 for an example how to fix issues with synchronized. Created attachment 78072 [details]
patch to remove synchronized
Here is the patch to remove the synchronized on internalGetChildren
Patch is good. When testing, we'll need to watch out for duplicate children under filters! Even before this change you could get duplicate children under filters. Bug #192884 is open for this. Will see if I can duplicate it again on Thursday. I've committed the patch for this to cvs. |