Bug 199031

Summary:	[api] AbstractSystemWizardPage should not implement ISystemMessageLine
Product:	[Tools] Target Management	Reporter:	Uwe Stieber <uwe.st>
Component:	RSE	Assignee:	dsdp.tm.rse-inbox <tm.rse-inbox>
Status:	NEW ---	QA Contact:	Martin Oberhuber <mober.at+eclipse>
Severity:	enhancement
Priority:	P3	CC:	martin.gutschelhofer, tobias.schwarz
Version:	2.0	Keywords:	api
Target Milestone:	Future
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Uwe Stieber

2007-08-07 05:13:14 EDT

The implementation of AbstractSystemWizardPage can be made more reliable, smaller and better extendable if dropping the use of ISystemMessageLine for this page. The messages are already redirected into the standard wizard message area and a cleanup of the API and implementation should be done to remove unnecessary code.

Comment 1 Martin Oberhuber

2007-08-07 09:22:26 EDT

I agree that AbstractSystemWizardPage should not implement ISystemMessageLine. Changed the Summary (previous value was:
  "Cleanup AbstractSystemWizardPage implementation and remove ISystemMessageLine  from list of implemented interfaces"

What we could do instead of implementing ISystemMessageLine, but still support the ISystemMessageLine (or similar IMessageManager) API for allowing RSE Widgets to print their messages to it, is have a getter:

  public ISystemMessageLine AbstractSystemWizardPage#getMessageLine();

though an even better solution would be to replace ISystemMessageLine by a more reliable and versatile interface like UI Forms / IMessageManager, see bug 199025.