Bug 198615

Summary:	[TOC][Editors] NLS processing instruction is not generated
Product:	[Eclipse Project] PDE	Reporter:	Wassim Melhem <wassim.melhem>
Component:	UI	Assignee:	Noam Chitayat <noam.chitayat>
Status:	RESOLVED INVALID	QA Contact:
Severity:	major
Priority:	P3	CC:	baumanbr, caniszczyk, curtispd, kitlo, mike.pawlowski
Version:	3.3	Keywords:	bugday
Target Milestone:	3.4 M4
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Wassim Melhem

2007-08-02 00:05:12 EDT

All the existing toc.xml in the SDK have this processing instructions:
<?NLS TYPE="org.eclipse.help.toc"?>

I believe it is used to signal to the translation teams to translate these xml files.

cc Curtis to comment on whether we should generate it by default.  I suspect that we should.

Comment 1 Brian Bauman

2007-08-02 09:26:29 EDT

Hey Noam, since you are doing a lot of work on the TOC editor, can you take care of this bug?  

Mike can review any patches.  If he doesn't have time, let me know and I can review them.

Comment 2 Curtis d'Entremont

2007-08-02 10:33:31 EDT

Kit, do you still need "<?NLS TYPE="org.eclipse.help.toc"?>" for help toc files?

Comment 3 Kit Lo

2007-08-02 10:39:50 EDT

Yes! Translators have different markup tables for different type of XML files telling them what should be translated, and what should be protected. Thanks!

Comment 4 Chris Aniszczyk

2007-11-11 21:35:24 EST

Noam, how about one for good old times?

Comment 5 Chris Aniszczyk

2007-11-12 21:09:19 EST

Hey Kit Lo, aren't about 100% of TOC's generated from within the big blue fortress? This string also doesn't really apply to anyone but us.

Also, if the NLS string is already in the TOC, we won't strip it out if the editor is used and we save the TOC.

I'm considering closing this bug as INVALID if you can't give me a better reason :D

Comment 6 Chris Aniszczyk

2007-11-15 15:14:42 EST

reopen if it's an issue.