Bug 196936

Summary: Connections of disabled systemTypes are shown (search, browse, systemView)
Product: [Tools] Target Management Reporter: Martin Oberhuber <mober.at+eclipse>
Component: RSEAssignee: Martin Oberhuber <mober.at+eclipse>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: minor    
Priority: P4    
Version: 2.0   
Target Milestone: 2.0.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 181939, 196942    

Description Martin Oberhuber CLA 2007-07-18 07:11:35 EDT 
+++ This bug was initially created as a clone of Bug #196934 +++

Start RSE, create a connection of type "Linux".
In Preferences, disable system type "Linux".
After Refresh in System View (bug #196930) it is no longer shown there; it's also not shown in the New Connection Wizard.

Click Search > Remote... and press the "Browse" button beside the "Folder" control. Click on the "Host" combo at the top of the dialog. The connection of type Linux is shown although it should be disabled.

It looks like the combo does not check adapter enablement as it should, by using either SystemWidgetHelpers.getValidSystemTypes() or by doing:

RSESystemTypeAdapter a = systemType.getAdapter(RSESystemTypeAdapter.class);
if (a.isEnabled(systemType)) { ...

See also bug #196934 and bug #196930 for similar issues.

-----------Enter bugs above this line-----------
TM 2.0
installation : eclipse-SDK-3.3 (I20070625-1500), cdt-4.0.0, emf-2.3.0
RSE install  : workspace HEAD
java.runtime : Sun 1.6.0_01-b06
os.name:     : Windows XP 5.1, Service Pack 1
------------------------------------------------
systemtype   : Windows-local, Dstore-win, Dstore-linux
targetos     : Red Hat Enterprise Linux WS release 4 (Nahant Update 3)
targetuname  : Linux parser 2.6.9-34.EL #1 i686 athlon i386 GNU/Linux
targetvm     : Sun Java HotSpot(TM) Client VM (build 1.4.2_12-b03, mixed mode)
------------------------------------------------
Comment 1 Martin Oberhuber CLA 2007-07-18 07:25:14 EDT 
The problem seems to be somewhere in SystemRemoteResourceDialog which is also re-used by the Export wizard, the EFS Select Filesystem UI and others.

Kevin -- I think you've been dealing with these dialogs in the past, could you have a look? I think the best would be to use SystemWidgetHelpers.getValidSystemTypes() in order to restrict to valid system types only.
Comment 2 Martin Oberhuber CLA 2007-07-18 08:44:46 EDT 
[196936] Hide disabled system types

Fixed in SystemSearchPage, SystemView, SystemViewPart, SystemTypeFieldEditor, SystemHostCombo
Comment 3 Martin Oberhuber CLA 2007-07-19 07:17:35 EDT 
The fix also helps initializing SubsystemConfigurations later (lazy loading) because it uses the SubSystemConfigurationProxy only. Because of this lazy loading, it is also related to bug #196942.