Bug 194464

Summary:

[telnet] Cannot create multiple telnet shells in quick succession

Product:

[Tools] Target Management

Reporter:

Martin Oberhuber <mober.at+eclipse>

Component:

RSE

Assignee:

Sheldon <sheldond>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

Keywords:

contributed, helpwanted

Version:

2.0

Target Milestone:

2.0.1

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

187301

Bug Blocks:

Attachments:

Description	Flags
patch for bug 194464	mober.at+eclipse: iplog+

Description Martin Oberhuber

2007-06-26 13:56:06 EDT

+++ This bug was initially created as a clone of Bug #187301 +++

Found by code Review: In TelnetConnectorService, when makeNewTelnetShell() is called in quick succession by multiple threads (e.g. because a program like the Linux Shell Processes Subsystem tries to open multiple shells), the two threads can interfere because "in" and "out" are instance variables shared by the connect thread.

The streams should either be created directly in the connect thread, or passed from the master method into the connect thread through the constructor instead.

Comment 1 Sheldon

2007-06-27 09:52:43 EDT

Created attachment 72599 [details]
patch for bug 194464

the input and output streams are now passed into the connect thread from master method through the constructor.

Comment 2 Martin Oberhuber

2007-07-04 11:59:36 EDT

Patch released for 2.0.1 -- thanks!