Bug 193380

Summary:

[Refresh] Deleting Connection Refresh's Entire Remote Systems View

Product:

[Tools] Target Management

Reporter:

Kevin Doyle <kjdoyle>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

CLOSED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

dmcknigh, kmunir

Version:

2.0

Keywords:

contributed

Target Milestone:

2.0.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Removed refresh() call and added remove(multiSource)	mober.at+eclipse: iplog+

Description Kevin Doyle

2007-06-19 14:49:27 EDT

If you delete a connection the entire Remote Systems View is refreshed.  All folders expanded on other connections become collapsed!

Steps to Reproduce:
1. Create a 1 or 2 connections.
2. Connect and expand some folders in those connections.
3. Delete your LOCAL connection.
--> All folders expanded are collapsed from the other connections.

We are doing a refresh() in SystemView.RefreshChangedJob.runInUIThread() for the case of EVENT_DELETE_MANY.  What we should be doing is a remove(IHost).

-----------Enter bugs above this line-----------
TM 2.0RC3 Testing
installation : eclipse-SDK-3.3RC4
RSE install  : RSE 2.0 RC3
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------

Comment 1 Kevin Doyle

2007-07-04 16:16:12 EDT

Created attachment 73068 [details]
Removed refresh() call and added remove(multiSource)

Deleting a connection would refresh the entire view because the code checks the parentItem and it it's the Tree it refresh's the entire tree.  Instead I added code, so it just makes a remove call.

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.

Comment 2 David McKnight

2007-07-04 16:37:08 EDT

I've committed the patch to cvs.  Thanks.

Comment 3 Kevin Doyle

2007-07-05 13:34:33 EDT

Verified with I20070705-0600.