Bug 192275

Summary:

[Schema][Editors] Should not be able to specify an element reference to the "extension" element

Product:

[Eclipse Project] PDE

Reporter:

Mike Pawlowski <mike.pawlowski>

Component:

Assignee:

Adam Archer <agarcher>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

wassim.melhem

Version:

3.3

Keywords:

contributed

Target Milestone:

3.4 M1

Flags:

mike.pawlowski: review+

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	mike.pawlowski: review+

Description Mike Pawlowski

2007-06-12 15:52:41 EDT

Definition Page -> Extension Point Elements Section

Steps To Reproduce:

(1) Open any schema containing an "extension" element node
(2) Select any compositor
(3) Select "New > Reference > extension"
    -> Bug: "extension" element is the root node of the contributed grammar,
       it should never be a child element of another element

Expected Behaviour:

The "extension" element should never be offered as a valid child element reference.

Comment 1 Adam Archer

2007-07-10 12:11:13 EDT

Created attachment 73438 [details]
patch

Checks if the elements are instances of SchemaRootElement before adding actions to the submenu.

Comment 2 Mike Pawlowski

2007-07-10 13:00:29 EDT

Comment on attachment 73438 [details]
patch

Nice clean patch Adam, Thanks.

Comment 3 Mike Pawlowski

2007-07-10 13:01:36 EDT

Patch released to HEAD.

Target:  3.4 M1