Bug 191176

Summary:	JavaProject#getOption optimizations
Product:	[Eclipse Project] JDT	Reporter:	Maxime Daniel <maxime_daniel>
Component:	Core	Assignee:	Olivier Thomann <Olivier_Thomann>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jarthana, Olivier_Thomann, srikanth_sankaran
Version:	3.3
Target Milestone:	3.6 M1
Hardware:	PC
OS:	All
Whiteboard:

Description Maxime Daniel

2007-06-06 03:20:36 EDT

Source based, v_770.

The current code for JavaProject#getOption could be optimized along the following:
- the propertyName local variable is a mere rename of the optionName parameter; use the parameter instead (with or without renaming it);
- the code should be written in a way that warranties that JavaCore.getOption(propertyName) only gets called if strictly needed.

Comment 1 Olivier Thomann

2009-06-25 15:32:10 EDT

The local variable can indeed be removed.

Comment 2 Olivier Thomann

2009-07-28 10:13:51 EDT

Released for 3.6M1.
Variable is removed. Code verification is required.

Comment 3 Jay Arthanareeswaran

2009-08-04 04:40:12 EDT

Verified for 3.6M1 by code inspection