Bug 189934

Summary:

[WorkingSets] Break apart working set action set

Product:

[Eclipse Project] Platform

Reporter:

Kim Horne <eclipse>

Component:

Assignee:

Kim Horne <eclipse>

Status:

VERIFIED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

martinae, Mike_Wilson

Version:

3.3

Keywords:

polish

Target Milestone:

3.3 RC3

Flags:

eclipse: pmc_approved? (Mike_Wilson)

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch against org.eclipse.ui.ide	eclipse: review?

Description Kim Horne

2007-05-30 10:41:27 EDT

From discussions in bug 180926 it was requested that I break apart the working set into two action sets - one that provides for the ability to change the window working set and the other to modify the contents of the sets themselves.  

I have such a patch available and would like to get it in for RC3 if possible.  If not, I wont lose sleep over it.

Comment 1 Kim Horne

2007-05-30 10:43:27 EDT

Created attachment 69293 [details]
Patch against org.eclipse.ui.ide

The gotcha for this one is that it causes a few new strings to be generated in the  plugin properties.

Comment 2 Martin Aeschlimann

2007-05-30 12:28:12 EDT

I think we better do this fix as it will bring back the 'Window Working Set' selection button and menus which otherwise would be hidden by default. Several views and dialog offer a Window Working Set filter.

Comment 3 Kim Horne

2007-05-30 12:52:19 EDT

This patch doesn't include the default=true flag for the window working set action set.  I didn't think breaking them apart would alleviate peoples annoyance with having 1 button instead of 0.

Comment 4 Mike Wilson

2007-05-30 13:58:42 EDT

+1 to the patch to split it into two actions sets

Comment 5 Kim Horne

2007-05-30 14:06:31 EDT

Fix in HEAD.

Comment 6 Kim Horne

2007-05-31 10:09:23 EDT

Verified in I20070531-0010