Bug 189150

Summary:

Incorrect Right Click Menu in Scratchpad after Clear Action Used

Product:

[Tools] Target Management

Reporter:

Kevin Doyle <kjdoyle>

Component:

RSE

Assignee:

Kushal Munir <kmunir>

Status:

CLOSED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

kmunir

Version:

2.0

Keywords:

contributed

Target Milestone:

2.0.1

Flags:

ddykstal.eclipse: review+

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
After performing a clear operation the selection is set to null	none
Updated to includes comments on _selectionFlagsUpdated = false	none
Updated for latest code changes	mober.at+eclipse: iplog+

Description Kevin Doyle

2007-05-25 10:56:14 EDT

After using the clear selection and clear all actions in the scratchpad and right clicking, the context menu is incorrect.

The original right click menu is also incorrect before adding objects to the scratchpad, as Refresh doesn't show up and Properties shouldn't be displayed.

-----------Enter bugs above this line-----------
TM 2.0RC1 Testing
installation : eclipse-SDK-3.3M7
RSE install  : I20070524-0915
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------

Comment 1 Kevin Doyle

2007-05-25 11:27:46 EDT

Created attachment 68791 [details]
After performing a clear operation the selection is set to null

This patch sets the selection to null after performing the clear operations and displays the refresh action on first right click in the empty scratchpad.

Kushal and I reviewed this patch earlier.

I will create a separate bug for the preference action being displayed in the right click menu when nothing is selected as it also appears on text.

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.

Comment 2 Kevin Doyle

2007-05-25 11:35:28 EDT

bug 189162 has been opened about preference action being displayed with nothing selected or a string of text being selected.

Comment 3 David Dykstal

2007-06-04 21:16:43 EDT

Please add some non-javadoc comments describing what the _selectionFlagsUpdated does and why setting it false should force a rescan of the selections. Other than that it looks good.

Comment 4 Kevin Doyle

2007-06-05 10:00:42 EDT

Created attachment 70132 [details]
Updated to includes comments on _selectionFlagsUpdated = false

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.

Comment 5 Kevin Doyle

2007-07-04 13:47:42 EDT

Created attachment 73047 [details]
Updated for latest code changes

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.

Comment 6 David McKnight

2007-07-04 13:52:54 EDT

I've committed Kevin's patch for this.

Comment 7 Martin Oberhuber

2007-07-04 14:48:16 EDT

Dave can you set the "contributed" flag for bug #194463 as well?

Comment 8 Kevin Doyle

2007-07-05 13:49:55 EDT

Verified with I20070705-0600.