Summary: | Warning not issued when non-instantiable class is bypassed in sampe JSPs | ||||||
---|---|---|---|---|---|---|---|
Product: | [WebTools] WTP Webservices | Reporter: | Andrew Mak <makandre> | ||||
Component: | jst.ws | Assignee: | Andrew Mak <makandre> | ||||
Status: | CLOSED FIXED | QA Contact: | Chris Brealey <cbrealey> | ||||
Severity: | normal | ||||||
Priority: | P3 | CC: | david_williams, hjzhang, kathy | ||||
Version: | 2.0 | Keywords: | contributed, PII | ||||
Target Milestone: | 3.0 RC1 | Flags: | david_williams:
pmc_approved+
kathy: pmc_approved? (raghunathan.srinivasan) kathy: pmc_approved? (naci.dai) kathy: pmc_approved? (deboer) kathy: pmc_approved? (neil.hauge) kathy: pmc_approved? (kaloyan) |
||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | PMC_approved | ||||||
Attachments: |
|
Description
Andrew Mak
2007-04-12 12:39:36 EDT
Over to you, Gil. Andrew, please add the message to this release. Created attachment 98672 [details]
patch
The proposed warning message is:
The input type {0} is a non-instantiable type and will be omitted from the sample JSP. Continue with sample JSP generation?
When the sample JSP generator encounters an input type that cannot be instantiated via the jsp:useBean tag, the method using that type is simply omitted from the generated sample JSP. There is no warning when the wizard is running nor does the generate pages indicate that some methods are omitted. This is not very user friendly. The fix involves setting the status with an appropriate warning message when non-instantiable classes are encountered. Previously an OK status is returned from this block of code. There are also a couple changes made so that clicking cancel from the warning dialog will terminate the wizard flow. I've tested this using the test files from bug 180952. Kathy, please review this patch. Patch reviewed. Thanks Andrew! PMC, please approve for WTP 3.0 RC1. I'll approve this one, and appreciate the efforts to improve usability, but ... it's pretty late to be making changes that involve PII, so, please use care, Kathy. (Or, explain better why it's so bad or such a high priority). Thanks for approving! Yes, I realize it's a bit late to make PII changes. This one missed the sweep when we check for defects that requires PII changes. Since this one would improve usability and let the user know what's going on, I tried to get this in for WTP 3.0 rather than waiting for the next release. I've committed the patch and released to HEAD as v200805091419. Verified on wtp-S-3.0RC3-20080529235434. |