Bug 17889

Summary: Should not assume type of PropertyChangeEvent values
Product: [Eclipse Project] Platform Reporter: Nick Edgar <n.a.edgar>
Component: CompareAssignee: Dirk Baeumer <dirk_baeumer>
Status: VERIFIED FIXED QA Contact:
Severity: critical    
Priority: P1    
Version: 2.0   
Target Milestone: 2.0 F2   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Nick Edgar CLA 2002-05-26 21:59:35 EDT 
Build 20020521

The following code should not make assumptions about the type of 
PropertyChangeEvent values.  Property change listeners must be prepared to 
handle String values as well as wrapped objects in the event.
See bug 16970 for more details.

org.eclipse.compare.internal.Utilities.getValue(PropertyChangeEvent, boolean)

There may be other places that need to be changed.
Should check all senders of getNewValue() and getOldValue().
Comment 1 Andre Weinand CLA 2002-05-27 05:26:11 EDT 
fixed for 20020528
Comment 2 Erich Gamma CLA 2002-06-02 17:50:20 EDT 
pls verify
Comment 3 Dirk Baeumer CLA 2002-06-03 10:40:35 EDT 
Method is gone in Utilities class
Comment 4 Dirk Baeumer CLA 2002-06-03 10:40:53 EDT 
Moving to verified bucket