NEW DATE! Bugzilla will undergo maintenance 2024-03-28 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 17889 - Should not assume type of PropertyChangeEvent values
Summary: Should not assume type of PropertyChangeEvent values
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 critical (vote)
Target Milestone: 2.0 F2   Edit
Assignee: Dirk Baeumer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-05-26 21:59 EDT by Nick Edgar CLA
Modified: 2002-06-03 10:40 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2002-05-26 21:59:35 EDT
Build 20020521

The following code should not make assumptions about the type of 
PropertyChangeEvent values.  Property change listeners must be prepared to 
handle String values as well as wrapped objects in the event.
See bug 16970 for more details.

org.eclipse.compare.internal.Utilities.getValue(PropertyChangeEvent, boolean)

There may be other places that need to be changed.
Should check all senders of getNewValue() and getOldValue().
Comment 1 Andre Weinand CLA 2002-05-27 05:26:11 EDT
fixed for 20020528
Comment 2 Erich Gamma CLA 2002-06-02 17:50:20 EDT
pls verify
Comment 3 Dirk Baeumer CLA 2002-06-03 10:40:35 EDT
Method is gone in Utilities class
Comment 4 Dirk Baeumer CLA 2002-06-03 10:40:53 EDT
Moving to verified bucket