Bug 177197

Summary:

Scripting event tags are reported as HTML_DEFAULT instead of a SCRIPT partition type

Product:

[WebTools] WTP Source Editing

Reporter:

Bradley Childs <childsb>

Component:

wst.html

Assignee:

Nitin Dahyabhai <thatnitind>

Status:

VERIFIED FIXED

QA Contact:

David Williams <david_williams>

Severity:

normal

Priority:

CC:

berkland, for.work.things, goodmanr

Version:

1.5

Keywords:

api, core

Target Milestone:

3.0 M3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch for StructuredTextPartitionerForHTML to include SCRIPT partitioning of EVENT attribute tags.	none
alternate patch	none

Description Bradley Childs

2007-03-13 15:49:07 EDT

The scripting event tags attribute values as defined at:
http://www.w3.org/TR/html4/interact/scripts.html#events
are erroneously reported as HTML_DEFAULT by StructuredTextPartitionerForHTML.

Comment 1 Bradley Childs

2007-03-13 15:54:26 EDT

Created attachment 60722 [details]
Patch for StructuredTextPartitionerForHTML to include SCRIPT partitioning of EVENT attribute tags.

Patch for StructuredTextPartitionerForHTML to include fix SCRIPT partitioning of EVENT tags attribute value text region.

Comment 2 Nitin Dahyabhai

2007-10-24 05:40:42 EDT

Created attachment 81041 [details]
alternate patch

The original patch would end up creating too many garbage strings, I think, with all of those substrings being used.  This patch updates it slightly to do a character array comparison in the partitioner if possible.  I tried long and hard to make the comparison in the parser's region factory so that the partitioner could just check the text region implementation class, but it became too big a change to also work in JSP files.  This one's actually a compromise between the the original and my own first pass.

Comment 3 Nitin Dahyabhai

2007-10-24 05:49:59 EDT

Released for M3.

Comment 4 Amy Wu

2007-11-13 20:42:19 EST

verified using wtp3.0M3 20071111084533 sdk

except i found 4 tag scripting events that are still not considered script partitions.  i opened bug 209737 to track the outstanding issue.