Bug 1763

Summary:	Add Filter button disable until something to add (1GLE2J4)
Product:	[Eclipse Project] JDT	Reporter:	Darin Swanson <Darin_Swanson>
Component:	Debug	Assignee:	Darin Swanson <Darin_Swanson>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	carolynmacleod4, eclipse
Version:	2.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Darin Swanson

2001-10-10 22:18:55 EDT

DS (10/10/2001 11:25:56 AM)
	The "Add Filter" button of the step filtering is always enabled.
	Should only be enabled when there is some text in the text area.

NOTES:

Comment 1 Darin Wright

2001-10-15 11:52:55 EDT

In consideration with CM's comments about layout.

Comment 2 Joe Szurszewski

2001-10-19 18:55:21 EDT

It would be nice if we instead of opening a dialog just to capture the filter 
string, we could do in place editing in the table viewer.  Will investigate.

Comment 3 DJ Houghton

2001-10-24 06:40:11 EDT

PRODUCT VERSION:
203++

Comment 4 Joe Szurszewski

2001-10-29 18:56:53 EST

Implemented in-place editing of new filters.  The usual keystrokes apply to 
such editing, CR commits change, ESC aborts.  Carolyn, what do you think?

Comment 5 Joe Szurszewski

2001-10-29 18:57:08 EST

Fixed.

Comment 6 Carolyn MacLeod

2001-10-30 10:12:12 EST

I'm not sure what I think. At first guess it seems like overkill,
and I don't know what the "Add new" mechanism looks like now.
Did you keep the "add package/type" dialogs?
Those helped the user by providing a list to select from.
I will have to try it to know for sure.

Comment 7 Darin Wright

2001-10-31 15:07:46 EST

Verified - available in next build. I like the layout/in place addition.