Bug 169

Summary:	Property page fails silently when disconnected (1GF9HEQ)
Product:	[Eclipse Project] Platform	Reporter:	John Arthorne <john.arthorne>
Component:	Team	Assignee:	Jeff Brown <jeff_brown>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	James_Moody
Version:	2.0
Target Milestone:	2.0 M6
Hardware:	All
OS:	Windows 2000
See Also:	https://github.com/eclipse/triquetrum/pull/274 https://github.com/eclipse/triquetrum/pull/275
Whiteboard:

Description John Arthorne

2001-10-10 21:37:34 EDT

VCMPropertyPage tries to contact the server before control is created

in VCMPropertyPage#createControl, the call to initialize() should come after
the call to setControl().  Otherwise, if errors occur during initialize (for example
if the server is down), it has no way of opening an error dialog because it has no parent control yet.

NOTES:

JohnA (6/13/2001 9:38:28 AM)
	Recommend deferring.  Behaviour is not bad (no error shown to user, but an error is logged,
	the property page shows the last known values for base, common, remote).

Comment 1 Kevin McGuire

2002-04-17 16:56:16 EDT

Behaviour now is you get a not obvious error - "Cannot create part: Properties".

Closing the properties page also generates an error.

Comment 2 Jeff Brown

2002-04-18 18:42:54 EDT

Remark: In Team 2.0, this functionality is assumed by CVSRemote[File/Folder]
PropertyPage.

Comment 3 Jean-Michel Lemieux

2002-04-22 12:41:57 EDT

Fix released to HEAD.

Comment 4 Eclipse Genie

2017-09-17 23:39:03 EDT

GitHub Pull Request 274 created by [cxbrooks]
https://github.com/eclipse/triquetrum/pull/274

Comment 5 Eclipse Genie

2017-09-18 01:41:00 EDT

GitHub Pull Request 275 created by [cxbrooks]
https://github.com/eclipse/triquetrum/pull/275