Bug 164450

Summary:	[comments] DefaultCommentMapper should release scanner after use
Product:	[Eclipse Project] JDT	Reporter:	Martin Aeschlimann <martinae>
Component:	Core	Assignee:	Frederic Fusier <frederic_fusier>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	performance
Version:	3.2
Target Milestone:	3.3 M4
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Martin Aeschlimann

2006-11-14 06:29:01 EST

20061114
If I understand right, the scanner used in the DefaultCommentMapper is only used when computing the ranges.
All accesses to extended ranges are simple lookups in an array on no use of the scanner is required.

The scanner still holds the char[] of the soirtce content which can be quite big.

Comment 1 Frederic Fusier

2006-11-17 10:46:40 EST

Fixed in method DefaultCommentMapper#initialize(CompilationUnit, Scanner).
Released for 3.3 M4 in HEAD stream.
No test case added.

Comment 2 David Audel

2006-12-12 06:16:01 EST

Verified for 3.3M4 with I20061212-0010.