Bug 163349

Summary:	[assist] code assist doesn't correctly use scanner eofPosition
Product:	[Eclipse Project] JDT	Reporter:	David Audel <david_audel>
Component:	Core	Assignee:	David Audel <david_audel>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Olivier_Thomann
Version:	3.3
Target Milestone:	3.3 M4
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	161400

Description David Audel

2006-11-03 11:26:46 EST

Completion engine use the fact that the scanner doesn't really stop to scan at Scanner.eofPosition.

If completion is inside a method body then completion engine intialize the scanner eofPostion at the location the completion. But it use the fact that the scanner will scan util the end of the current token.
e.g. fo|o = null;
the eofPosition will be at | but the scanner will scan until the end of foo. The completion engine use this position as the end of the completion token.

This can be considered as a non correct use and a fix to bug 161400 will change this property of the scanner.
Completion process should be adapted to support the fix of 161400.

Comment 1 Olivier Thomann

2006-11-03 11:31:18 EST

Both fixes should be released at the same time.

Comment 2 Olivier Thomann

2006-11-06 16:44:30 EST

Released for 3.3M4.
David, I released since I released the code for bug 161400.

Comment 3 Olivier Thomann

2006-12-11 14:22:04 EST

Verified for 3.3M4 with I20061211-1119