Summary: | [compiler] Anonymous and local classes are tagged as final and/or private in the inner class infos | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Olivier Thomann <Olivier_Thomann> | ||||||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||||
Severity: | normal | ||||||||||
Priority: | P3 | CC: | nbeyer, philippe_mulet, t.p.ellison | ||||||||
Version: | 3.3 | ||||||||||
Target Milestone: | 3.2.2 | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Whiteboard: | |||||||||||
Attachments: |
|
Description
Olivier Thomann
2006-10-25 15:46:05 EDT
See also: Bug#162356. Created attachment 52795 [details]
Proposed fix
Created attachment 52796 [details]
Regression tests
Created attachment 52799 [details] Updated regression tests Regression test for bug 162356 needs to be updated (changes in the disassembled output). Released for 3.3M3. If we fix in 3.2.2, I would not backport the changes in the disassembler. Just the one in ClassFile and the patch for HEAD is applicable for 3.2 maintenance. +1 for 3.2.2. Our current behavior violates the spec. Verified for 3.3 M3 using build I20061030-0010 Released for 3.2.2. Reopen for verification (In reply to comment #9) > Released for 3.2.2. > Checked the generated code for EnclosingMethodAttributeTest#test002. Verified for 3.2.2 using build M20070112-1200. Tim, Please have a look at bug 171749. I think we should also remove the final bit from the access flag of the class file. We removed it from the inner info entry, but not from the class file access flag. See bug 240214. |